search

MartinPacker / filterCSV

Tools to manipulate CSV files in a format suitable for importing into various mindmapping programs - such as iThoughts, Freemind, and MindNode.
MIT License
32 stars 8 forks source link

Shortened code #98

Closed jbaenaxd closed 2 years ago

MartinPacker commented 4 years ago

Hi @jbaenaxd! Thank you for your (first) contribution to the project.

This pull request generated problems with both checks. While I’m inclined to accept the PR, can you check why these failed - and maybe rework slightly to avoid the failures?

Also, while I’m all for elegant code, what was the purpose of one-lining these lines?

Anyhow, I hope you don’t feel discouraged - and welcome aboard!

Cheers, Martin

MartinPacker commented 4 years ago

So the Travis failure is due to line length - which is yours to fix, I’m afraid. (I don’t think the logic needs to change but the line needs splitting.)

The other one is a misspelling of “attribute”. I don’t know if this is yours but I’d be grateful if you fixed it - if it’s in the part you improved.

Thanks, Martin

MartinPacker commented 2 years ago

I'm about to start work on filterCSV again. So cleaned up.