search

MartinPdeS / PyMieSim

Python package for Mie scattering computation and analysis.
MIT License
22 stars 5 forks source link

polarization filter angle in rad instead of degrees #14

Closed riddlecul closed 8 months ago

riddlecul commented 8 months ago

Contrary to all other angles (gamma_offset, phi_offset, source polarization_value) which are to be given in degrees, the detector's polarization_filter is to be given in rad. This is not documented and also the default plots show it as if were degrees. I'd suggest to changing to degrees for consitency with the other angles.

MartinPdeS commented 8 months ago

Thanks for pointing that out. I may have forgotten the translation from deg to rad. I will investigate that on the weekend.

MartinPdeS commented 8 months ago

The problem was fixed in the new 1.6.6 version, unit tests for consistency assertion were added too.

riddlecul commented 8 months ago

Luckily, it was easy to fix. Works as expected now - thanks for fixing it so quickly!