MartinRybergLaude / solsken-weather

A weather app that works everywhere, anytime.
European Union Public License 1.2
1 stars 0 forks source link

Some issues and ideas #17

Open Johnnywick1 opened 4 months ago

Johnnywick1 commented 4 months ago

Hi,

Nice app, but there is few issues:

  1. The map does not show the selected location.
  2. When you choose a place, there is no choice. There are many towns with the same name. There is no choice of state, province or country.
  3. There are no signed functions under the graph. It is not known what these lines under the graph mean.
  4. Is it possible that after entering the website, the location is automatically selected by IP address? (but not forced by the browser, because Google doesn't like it)

If you fix these bugs your app can put on whatweather.today (if you want)

Thank you

Johnnywick1 commented 4 months ago

Thank you for fixing map issue.

I found one more error. The hourly forecast always shows my local time instead of the local time of the city I have chosen.

Anyway, could you do it as it is in this scripts: https://github.com/WilliamsMata/weather-app, https://github.com/hellishBat/weatherinsight, https://github.com/devalentineomonya/ReactJS-Weather-App, https://github.com/chapmancbVCU/react-weather-app ? I mean when you first visit the website, a city is automatically found. Then, if someone chooses a different one, it is remembered as now in your script (but automatically found by IP in the first time).

Could you please leave the "Find your location" button? This button doesn't bother but it may help.

I don't know if you understood me about the towns that are being searched for (cause my bad English). Also take a look at this script: https://github.com/WilliamsMata/weather-app. When you are looking for a town with the same name, there is option to choose from which country, state or province.

I also have a suggestion to add a Windy.com or Ventusky.com map instead of this map now you gave. Example here: https://github.com/enesctnn/WeatherApp These maps have more options to check.

I'm sorry that I'm bothering you with my requests.

Thank you

MartinRybergLaude commented 4 months ago

Hi!

Thank you for the feedback! I'm working to address all points, very valuable insight. You're not bothering me at all! 😄

I understood the city thing, I will add province names below the location name itself to alleviate this, but the API I'm using is fairly limited so it won't be perfect.

Regarding Windy, I wanted to include it, but their licensing isn't sustainable for me. Including a webview is AFAIK against their TOS, and the pricing for their leaflet integration isn't good enough.

Edit: Checked out Ventusky as well, same deal I'm afraid! CleanShot 2024-05-02 at 11 19 29@2x