search

MartinSGill / SubnauticaWatcher

Adds a "live" map to the Subnautica game.
MIT License
56 stars 12 forks source link

Make it compatible with Qmod Manager on Nexus #20

Open ramonsantana opened 6 years ago

ramonsantana commented 6 years ago

Both apps use the same Assembly-Csharp.dll

Qwiso commented 6 years ago

My reply on my repo gives a manual fix but I'll plan to allow a way of running my installer in a "compatibility mode" which won't overwrite other injections

https://github.com/Qwiso/QModManager/issues/1#issuecomment-367169184

MartinSGill commented 6 years ago

@Qwiso you can look at/borrow my patching code, it already behaves that way.

Qwiso commented 6 years ago

@MartinSGill we both explicitly backup the original dll, is the issue.

MartinSGill commented 6 years ago

I can make that an option on the installer. The backup shouldn't be an issue, unless we both choose the same filename. Unless your mod does something with the backup?

I only back it up to make uninstalling easier, nothing of mine actually makes use of the backup. It's not strictly necessary as a Steam validate will restore the missing/patched file. So I could just turn that feature off.

Qwiso commented 6 years ago

Sorry for not being clearer. Both of our installers will inject and function, I've tested that just now

What I noticed, when using File.Copy for backup we should ensure the version of Assembly-CSharp.dll is clean of other patching methods

Vlad-00003 commented 6 years ago

I don't get it. I got both - qmod and watcher. They both work just fine.... And I've also modified the assembly myself a bit, so.... No compability problems here =)