search

MartinSGill / TodoTxtJs

A Javascript web app implementation of TodoTxt
72 stars 29 forks source link

feature request: specify timezone #67

Closed knodalyte closed 10 years ago

knodalyte commented 10 years ago

Your server, presumably in UK, thinks some of my todos are overdue although they are due today here in the US of A. Perhaps you could allow us to enter our local timezone (or sniff it from our request) and adjust your app's logic when determining whether a todo is overdue or not.

Very nice little app, saves me having to have some other desktop app open just to see or add to my todo.txt. Thank you!

MartinSGill commented 10 years ago

Hi Craig, glad you like it.

I think this is the same issue as #51. The app should be timezone agnostic, but I think it's using UTC instead. I've been trying to figure this one out for a while.

Time to take another go at it I think.

knodalyte commented 10 years ago

Hi Martin, Firebug indicates that moment.min.js is being loaded (so I know you have deployed this fix), but I am still seeing a task with the text "due:2014-03-17" as due yesterday in the "gui".

I think it's an "off by 1" defect, as all date presentations are incorrect, e.g. 2014-03-22 is showing as Friday.

MartinSGill commented 10 years ago

Well, guess that means I'm doing something wrong somewhere. Javascript should be doing everything in the local (browser) timezone. I'll need to do some more digging it seems.

MartinSGill commented 10 years ago

I played a hunch and figured it out.

Turns out in Javascript these two:

new Date("2014-03-17"); new Date(2014, 2, 17); // (months are zero indexed, so 2 is March.

Are not in the same timezone! The first is UTC, the second is local.

knodalyte commented 10 years ago

Dates are working fine now, thank you.

Are you in touch with the creator of the Android app called SimpleTask, which uses todo.txt on Dropbox? I have suggest to him via email that he might want to point to your web app in his description.

Regards, Craig

On Mon, Mar 17, 2014 at 5:12 PM, Martin Gill notifications@github.comwrote:

Closed #67 https://github.com/MartinSGill/TodoTxtJs/issues/67 via 5bd40dehttps://github.com/MartinSGill/TodoTxtJs/commit/5bd40dea03c92f32c2470143b97c7670c344c3ab .

Reply to this email directly or view it on GitHubhttps://github.com/MartinSGill/TodoTxtJs/issues/67 .

MartinSGill commented 10 years ago

Thanks for the promotion. My project is already mentioned on the main TodoTxt website.