search

MartinSGill / TodoTxtJs

A Javascript web app implementation of TodoTxt
72 stars 29 forks source link

Umlaut bug #77

Closed jannehukka closed 9 years ago

jannehukka commented 9 years ago

Hi Martin,

and thanks for your great TodoTxtJs!

I've noticed that the filtering doesn't work if the context name or project name includes letters with umlauts (Scandinavian/German/Finno-Ugric Ä,Ö etc.). Is there any chance you could take a look at that?

Best wishes,

Janne

MartinSGill commented 9 years ago

Hi Janne, glad you like.

I'm afraid I cannot reproduce this.

I tried the following todos:

Dies ist ein Todo @das_übliche 
Dies ist auch ein Todo @zuHause

Then filtered on @dasübliche e.g. http://todo.martinsgill.co.uk/?filter=%40das%C3%BCbliche and it works correctly, showing only the one item.

Could you please provide an example of something that doesn't work for you. Could you also please let me know the Operating System and Browser you are using, in case it's something specific to one of those.

jannehukka commented 9 years ago

Hi,

and thanks for your quick response.

Here are a few examples:

tämä on todo @kynällä tämä on toinen todo +päivällä tämä on kolmas todo @yöllä

All the words are searchable but the contexts and projects do not turn into clickable links. I get the same response as you did with @das_übliche.

I've used the program on OS Yosemite and iOS, browsers have mainly been the most up-to-date Firefox and Chrome.

Thanks again!

J.

keskiviikko 14. tammikuuta 2015 Martin Gill notifications@github.com kirjoitti:

Hi Janne, glad you like.

I'm afraid I cannot reproduce this.

I tried the following todos:

Dies ist ein Todo @das_übliche Dies ist auch ein Todo @zuHause

Then filtered on @dasübliche e.g. http://todo.martinsgill.co.uk/?filter=%40das%C3%BCbliche and it works correctly, showing only the one item.

Could you please provide an example of something that doesn't work for you. Could you also please let me know the Operating System and Browser you are using, in case it's something specific to one of those.

— Reply to this email directly or view it on GitHub https://github.com/MartinSGill/TodoTxtJs/issues/77#issuecomment-69918980 .

jannehukka commented 9 years ago

Amazing, that's perfect, thanks a lot.

For what it's worth, TodoTxtJs is simply the best todo.txt implementation that I've tried. The only thing I'm missing is alphabetic sorting of the list.

But again, great work!

Best wishes,

Janne

lauantai 31. tammikuuta 2015 Martin Gill notifications@github.com kirjoitti:

Closed #77 https://github.com/MartinSGill/TodoTxtJs/issues/77 via c203c24 https://github.com/MartinSGill/TodoTxtJs/commit/c203c24f1286d5fdd78d0ab4af06e0228efa38dc .

— Reply to this email directly or view it on GitHub https://github.com/MartinSGill/TodoTxtJs/issues/77#event-227997374.