SIM112: Non-capital environment variables

[MartinThoma]

Explanation

It is pretty common to have CONSTANT_STYLE environment variables.

Example

# Bad
os.environ["foo"]
os.environ.get("bar")

# Good
os.environ["FOO"]
os.environ.get("BAR")

[MartinThoma]

        Expr(
            value=Subscript(
                value=Attribute(
                    value=Name(id='os', ctx=Load()),
                    attr='environ',
                    ctx=Load(),
                ),
                slice=Index(
                    value=Constant(value='foo', kind=None),
                ),
                ctx=Load(),
            ),
        ),

[MartinThoma]

        Expr(
            value=Call(
                func=Attribute(
                    value=Attribute(
                        value=Name(id='os', ctx=Load()),
                        attr='environ',
                        ctx=Load(),
                    ),
                    attr='get',
                    ctx=Load(),
                ),
                args=[Constant(value='bar', kind=None)],
                keywords=[],
            ),
        ),

[MartinThoma]

Included in v0.10.0