[SIM905] Use list of strings instead of splitting a constant string

[MartinThoma]

Explanation

You want a list of strings? Create one directly:

• A list of strings can be formatted by black.
• Your editor can sort the lines
• You don't have to worry about how to keep leading / intermediate / trailing spaces or how to add newlines to the strings

Example

# Bad
domains = "de com net org".split()

# Good
domains = ["de", "com", "net", "org"]

[MartinThoma]

$ astpretty --no-show-offsets /dev/stdin <<< `cat example.txt`
Module(
    body=[
        Assign(
            targets=[Name(id='domains', ctx=Store())],
            value=Call(
                func=Attribute(
                    value=Constant(value='de com net org', kind=None),
                    attr='split',
                    ctx=Load(),
                ),
                args=[],
                keywords=[],
            ),
            type_comment=None,
        ),
    ],
    type_ignores=[],
)

[MartinThoma]

The relevant part is:

Call(
    func=Attribute(
    value=Constant(value='de com net org', kind=None),
    attr='split',
    ctx=Load(),
)