MartinThoma / flake8-simplify

❄ A flake8 plugin that helps you to simplify code
MIT License
185 stars 19 forks source link

[New Rule] Use comparision directly instead of bool(comparison) #88

Closed martin-thoma closed 2 years ago

martin-thoma commented 2 years ago

Explanation

Comparisons return boolean values. No need to wrap it in a bool-call

Example

# Bad
bool(a == b)

# Good
a == b
MartinThoma commented 2 years ago
MartinThoma commented 2 years ago
$ astpretty --no-show-offsets /dev/stdin <<< `cat /home/moose/example.py`

astpretty --no-show-offsets /dev/stdin <<< `cat /home/moose/example.py`
Module(
    body=[
        Expr(
            value=Call(
                func=Name(id='bool', ctx=Load()),
                args=[
                    Compare(
                        left=Name(id='a', ctx=Load()),
                        ops=[Eq()],
                        comparators=[Name(id='b', ctx=Load())],
                    ),
                ],
                keywords=[],
            ),
        ),
    ],
    type_ignores=[],
)