search

MartinTopfstedt / FontAwesome5

WPF controls for the iconic SVG, font, and CSS toolkit Font Awesome 5.
MIT License
120 stars 23 forks source link

Implement Pulse animation #20

Closed helluvamatt closed 4 years ago

helluvamatt commented 4 years ago

I implemented the pulse animation on the original charri repository. That pull request is here. Unfortunately, I'm not sure if that repository is actually still active.

At first glance, it appears there is 3x the code here due to full support for UWP and .NET Core. I'm not sure why some of the code is not shared (eg. ISpinable, IRotatable), but it all seems possible to add the pulse animation. The animation is just a rotation with 8 descrete steps instead of a continuous rotation. For both UWP and WPF, it's done with the same code as the spin animation, but using a DoubleAnimationWithKeyframes and DiscreteDoubleKeyFrame.

Would there be any interest to implement that functionality here?

helluvamatt commented 4 years ago

Work-in-progress branch: https://github.com/helluvamatt/FontAwesome5/tree/feature/pulse

Still need to do examples and documentation. I will likely have to stop for today.

MartinTopfstedt commented 4 years ago

Hi, i improved the files a bit to share the code between .Net/.Net Core and UWP. If you want you can merge the new code and create a pull request to include your code.

Best regards, MArtin