NuGet dependency that is not platform specific

MartinTopfstedt / FontAwesome5

WPF controls for the iconic SVG, font, and CSS toolkit Font Awesome 5.

MIT License

118 stars 23 forks source link

NuGet dependency that is not platform specific #5

Closed dahovey closed 6 years ago

dahovey commented 6 years ago

For pull request #4 my intention was to create NuGet package that is not platform specific. This allows reference from cross-platform assemblies (i.e. MyApp.Mobile.ViewModels). Within an assembly like this, EFontAwesomeIcon can be a binding rather than entirely relying on views to determine an icon.

This also allows for testing logic. For example using a specific icon for each company type which can be verifying used tests.

MartinTopfstedt commented 6 years ago

Hi, just so i get this right. You want one Nuget package which includes the libraries of WPF and UWP?

dahovey commented 6 years ago

My intention was to have a NuGet package that is neither WPF or UWP. Just the C# EFontAwesomeIcon enum and extension methods, anything that is cross-platform.

But yes, one NuGet that has support for multiple frameworks would also work. Ideally this single NuGet package would include support for 3 target frameworks:

.NET Framework 4 (Would include FontAwesome5.dll and FontAwesome5.WPF.dll)
.NET Standard (Would just include FontAwesome5.dll)
UWP (Would include FontAwesome5.dll and FontAwesome5.UWP.dll)

MartinTopfstedt commented 6 years ago

Ok, i go with one nuget package, i don't like to have alot of dependency packages.

MartinTopfstedt commented 6 years ago

The FontAwesome5 package contains the .Net Standard 1.4 library which includes just the enumeration and the extension methods.