Open MartinWitt opened 2 years ago
@laughing-train config
@laughing-train list
I found 2 bad smells:
runMethods.size() == 0
can be replaced with 'runMethods.isEmpty()'
in command-airline/deployment/src/main/java/io/quarkiverse/githubapp/command/airline/deployment/GitHubAppCommandAirlineProcessor.java
.collect(Collectors.toList());
if (runMethods.size() == 0) {
continue;
}
Unnecessary toString()
call
in runtime/src/main/java/io/quarkiverse/githubapp/runtime/Routes.java
Files.createDirectories(gitHubAppRuntimeConfig.debug.payloadDirectory.get());
LOG.warn("Payloads saved to: "
+ gitHubAppRuntimeConfig.debug.payloadDirectory.get().toAbsolutePath().toString());
}
}
@laughing-train list