MartinWitt / quarkus-github-app

Develop your GitHub Apps in Java with Quarkus.
https://quarkiverse.github.io/quarkiverse-docs/quarkus-github-app/dev/index.html
Apache License 2.0
0 stars 0 forks source link

Dev #1

Open MartinWitt opened 2 years ago

MartinWitt commented 2 years ago

@laughing-train list

MartinWitt commented 2 years ago

@laughing-train config

MartinWitt commented 2 years ago

@laughing-train list

laughing-train[bot] commented 2 years ago

Bad smells

I found 2 bad smells:

SizeReplaceableByIsEmpty

runMethods.size() == 0 can be replaced with 'runMethods.isEmpty()' in command-airline/deployment/src/main/java/io/quarkiverse/githubapp/command/airline/deployment/GitHubAppCommandAirlineProcessor.java

Snippet

                    .collect(Collectors.toList());

            if (runMethods.size() == 0) {
                continue;
            }

UnnecessaryToStringCall

Unnecessary toString() call in runtime/src/main/java/io/quarkiverse/githubapp/runtime/Routes.java

Snippet

            Files.createDirectories(gitHubAppRuntimeConfig.debug.payloadDirectory.get());
            LOG.warn("Payloads saved to: "
                    + gitHubAppRuntimeConfig.debug.payloadDirectory.get().toAbsolutePath().toString());
        }
    }