Closed sp71 closed 5 years ago
Found the issue. Within appearance init, I saw the following lines
window.addEventListener("slidechangecomplete", showHideSlide, false);
window.addEventListener("fragmentshowncomplete", showHideFragment, false);
window.addEventListener("fragmenthiddencomplete", showHideFragment, false);
I fixed it by doing the following in apperance.js:
window.parent.addEventListener("slidechangecomplete", showHideSlide, false);
window.parent.addEventListener("fragmentshowncomplete", showHideFragment, false);
window.parent.addEventListener("fragmenthiddencomplete", showHideFragment, false);
Would be good to also consider iframe for other users of this repo. Any chance something like this could be added in?
Possible solution
var isIFramed = window.parent !== window.self
var win = isIFramed ? window.parent : window
win.parent.addEventListener("slidechangecomplete", showHideSlide, false);
win.parent.addEventListener("fragmentshowncomplete", showHideFragment, false);
win.parent.addEventListener("fragmenthiddencomplete", showHideFragment, false);
Thanks for the heads up! I'll look into the issue later this week.
Hi Satinder, the issue was not in Appearance, but in Transit.js, which tracks if a Reveal transition has really ended. I've changed it there, so you should be good to go now. Thanks!
I'm putting my reveal presentation within an iframe. All the plugins work for me except for this. Maybe because some event is not being captured because of the iframe? It works fine when there is no iframe. Any suggestions?