search

Martinsos / edlib

Lightweight, super fast C/C++ (& Python) library for sequence alignment using edit (Levenshtein) distance.
http://martinsos.github.io/edlib
MIT License
493 stars 162 forks source link

In Python package, directly support unicode strings #141

Closed Martinsos closed 4 years ago

Martinsos commented 4 years ago

If string is unicode, as described here: https://github.com/Martinsos/edlib/issues/140 , edlib (python) will still treat it as normal string (that is not unicode) and therefore will produce wrong results. We should detect if string should not be treated as single-char string and in such case we should apply different method internally (one for hashable objects which we already have implemented), or if we can't handle it (due to too big alphabet) we should throw error.

Martinsos commented 4 years ago

This is already implemented (silly me), so I am closing it!