Martinsos / edlib

Lightweight, super fast C/C++ (& Python) library for sequence alignment using edit (Levenshtein) distance.

http://martinsos.github.io/edlib

MIT License

493 stars 162 forks source link

Add windows command line support to aligner #94

Open randrick opened 6 years ago

randrick commented 6 years ago

You can get aligner to work on windows command line by inserting the following lines into aligner.ccp after line 8: #include \<queue>

ifdef _WIN32

include "getopt.h"

endif

include "edlib.h"

Then adding getopt.h file. The one I used is here: https://raw.githubusercontent.com/skandhurkat/Getopt-for-Visual-Studio/master/getopt.h although that's likely not the origin of the file.

Martinsos commented 6 years ago

@randrick Thank you for suggestion! I was looking at it as a possible solution, but I did not like the idea of adding external getopt.h file. However, it does sound like a good solution now.

Would you be up for creating a PR for this? I don't use Windows for development so it would be great if you could also test it a little bit.

There is already an issue for this: #56, I will close it in favor of this one. As mentioned there, we should also add aligner tests to appveyor.

randrick commented 6 years ago

I can create a PR, although I am not really a windows developer either. I really should have said, this change was to make the aligner compile using Visual Studio. It will compile on windows just fine with minGW compiler.

Martinsos commented 6 years ago

Yes that is completely fine, we want for people to be able to use edlib from visual studio also. Please do create a PR then when you have time :)!