MartySkinner / Indigo-apcupsd

APCUPSD (UPS daemon) plugin for Indigo home automation software
The Unlicense
1 stars 2 forks source link

Source command in event files missing argument #1

Open AaronLionsheep opened 7 years ago

AaronLionsheep commented 7 years ago

@MartySkinner The source /etc/apcupsd/tell_indigo command is missing another argument. Isn't the tell_indigo script expecting the first argument to be the actual event name, so the filename? If so then it should be: source /etc/apcupsd/tell_indigo $(basename $BASH_SOURCE)? The documentation does not include this extra parameter.

The external event notifications were not recognized at all without this extra parameter to tell the plugin what the event was. When this extra parameter $(basename $BASH_SOURCE) was included then the plugin was able to pickup on the external events.

MartySkinner commented 7 years ago

Thanks for pointing this out. I have updated the comments in the tell_indigo script and the README.md to reflect the expected command parameters. Please let me know how it works if you use the new command line.