Day Care debug UI bugfix

Maruno17 / pokemon-essentials

A heavily modified RPG Maker XP game project that makes the game play like a Pokémon game. Not a full project in itself; this repo is to be added into an existing RMXP game project.

Other

208 stars 398 forks source link

Day Care debug UI bugfix #126

Closed FL- closed 3 years ago

FL- commented 3 years ago

~~Fix some pokémon forms didn't inherit father form when breeding with Ditto~~.
Fix a debug daycare UI bug (if you have 2 pokémon on daycare and remove the first by debug menu, the second one disappears from UI).
~~Fix pokémon with impossible genders when changing species by debug~~.

FL- commented 3 years ago

Making a rebase

FL- commented 3 years ago

Done

Maruno17 commented 3 years ago

I don't think your changes related to gender are needed, given my recent commit to the dev branch which fixes the same thing but in a better way. And that change doesn't need porting into the master branch, because it only comes about while debugging and isn't important enough to be fixed immediately.

FL- commented 3 years ago

I didn't see your commit. Your commit was almost the same time as this pull request (less than 10 minutes difference).

Anyway, the gender fix was removed.

Maruno17 commented 3 years ago

I've just make a commit that includes this change but in a slightly better way. This pull request is no longer needed.

FL- commented 3 years ago

I guess that you forgot about the other bugfix. Look at description.