search

Maruno17 / pokemon-essentials

A heavily modified RPG Maker XP game project that makes the game play like a Pokémon game. Not a full project in itself; this repo is to be added into an existing RMXP game project.
Other
208 stars 398 forks source link

Updated HM/expAll/Switch Messages. #156

Closed Nathan-MV closed 2 years ago

Nathan-MV commented 2 years ago
Maruno17 commented 2 years ago

I've made this a draft because you're still throwing a bunch of nondescript commits at it.

Nathan-MV commented 2 years ago

I've made this a draft because you're still throwing a bunch of nondescript commits at it.

I clicked in the wrong place lol, it is already ready to be reviewed.

Maruno17 commented 2 years ago

You shouldn't have put two completely unrelated things into the same PR.

I'm very hesitant to add Defog's overworld effect. I think the main reason it is usable in the overworld (and only in Gen 4) is because fog has an in-battle effect, but that effect isn't coded into Essentials. Given that effect was very unpopular, I don't think many people want it either. Since it doesn't affect battle, fog weather is purely cosmetic, which means it probably shouldn't be removable by the player using Defog. I think it's best to let a plugin deal with Defog's overworld effect.

Nathan-MV commented 2 years ago

I'm very hesitant to add Defog's overworld effect. I think the main reason it is usable in the overworld (and only in Gen 4) is because fog has an in-battle effect, but that effect isn't coded into Essentials. Given that effect was very unpopular, I don't think many people want it either. Since it doesn't affect battle, fog weather is purely cosmetic, which means it probably shouldn't be removable by the player using Defog. I think it's best to let a plugin deal with Defog's overworld effect.

The Battle Rule in PR #155 to change the terrain to Misty when there's Fog Weather is the in-battle Fog effect in Gen 8(SWSH and BDSP).

(and only in Gen 4)

The Field Effect is present at BDSP(Gen 8).

Maruno17 commented 2 years ago

In SwSh you can't use Defog in the overworld to get rid of fog weather (even though it does affect battles via Misty Terrain). So that's one game where you can't and one game where you can, which is hardly conclusive. However, BDSP shouldn't really count, because it's a remake and thus not evidence of new games using that mechanic.

Given that there are far more core games which have fog but which do not let you remove it with Defog, I'd say Defog's overworld effect should be opt-in at best. And since I'm not willing to add Settings for every single little thing, and since the Defog code is entirely self-contained, I'd say it should be left to a plugin. If future games work the same as BDSP, I'll reconsider it, but for now there isn't enough evidence that it's worth it.