search

Maruno17 / pokemon-essentials

A heavily modified RPG Maker XP game project that makes the game play like a Pokémon game. Not a full project in itself; this repo is to be added into an existing RMXP game project.
Other
208 stars 398 forks source link

Adding Missing forms for Pikachu #160

Closed Golisopod-User closed 2 years ago

Golisopod-User commented 2 years ago

The Cosplay and Cap forms for Pikachu, introduced in Gens 6 and 7, are the only visible form changes that are missing from default Essentials. This PR adds the missing Pikachu forms to Essentials.

Maruno17 commented 2 years ago

I intentionally haven't added these, because they're stupid promotional stuff.

Golisopod-User commented 2 years ago

I think they're considered pretty important, because they have made an appearance in multiple main series games, unlike something like Partner Pikachu and Eevee from Let's Go. They also have new mechanics associated with them (the move switching code for Cosplay Pikachu), unlike Partner Pikachu. There are more examples of superficial and "obnoxious" form changes already implemented in Essentials, like Alcremie, Unown, Sinistea, Minior and more, so I really don't understand why Pikachu is the only one that gets neglected.

Maruno17 commented 2 years ago

The cosplay Pikachu only exist in ORAS, which is one main series game. Cap Pikachu do exist in multiple main series games, yes, but there's nothing special about them outside of their definitions in pokemon_forms.txt. Forced genders don't count, because they're easy to force when the Pokémon is obtained (and these things would definitely be obtained via an event rather than encountered in the wild).

Your code for the cosplay Pikachu looks like the code for Rotom, so it isn't new. There's an additional part of the mechanic which is new but which isn't in your code: if the cosplay Pikachu doesn't know a form-specific move when changing form, it is asked whether it wants to learn that new form's move, and it is unable to change forms if it refuses. (The move can be forgotten later, but it must be taught as part of a form change.) This additional part would belong in the event that changes Pikachu's form, though, so there's still no new code.

The whole gimmick of Pokémon like Alcremie, Unown, Sinistea and Minior are that they have multiple forms. Pikachu was created without such a gimmick. It may have alternate forms now, but they're still stupid promotional stuff and I'm not adding them to Essentials. They're not interesting, they're not necessary, they're not new mechanics that need showcasing, and they're not part of the identity of the species.