Maruno17 / pokemon-essentials

A heavily modified RPG Maker XP game project that makes the game play like a Pokémon game. Not a full project in itself; this repo is to be added into an existing RMXP game project.
Other
208 stars 398 forks source link

Implement TramplesMinimize as a move flag #174

Closed C-Ezra-M closed 2 years ago

C-Ezra-M commented 2 years ago

Implemented TramplesMinimize as a move flag. Due to it, removed effect codes FlinchTargetTrampleMinimize and ParalyzeTargetTrampleMinimize (the second one was exclusive to Body Slam). Moves that had them now have the effect codes FlinchTarget and ParalyzeTarget, respectively.

The code now does not check if the parameter of tramplesMinimize? is 1 or 2, it now checks if it is true or false. For the effect that causes the moves with this flag to skip accuracy checks, it also checks if Settings::MECHANICS_GENERATION is equal to or greater than 6.

Data on which moves are to be treated as able to double damage if Minimized and skip accuracy checks are here.

Remarks:

TL;DR:

C-Ezra-M commented 2 years ago

Please deny the commits "Remove an extra N from comment" (a663bc3) and "Merge branch 'dev' of https://github.com/Keyacom/pokemon-essentials i…" (03805f3)

This is because I forgot to copy the dev branch for this PR. I'm using GitHub Desktop and it doesn't notify me to create new branches for commits.

C-Ezra-M commented 2 years ago

After you review this PR and accept changes, I will delete my fork and then re-fork this repo. I'll be more careful with where to make changes from then on.

Maruno17 commented 2 years ago

Superseded by pull request #175.