search

Maruno17 / pokemon-essentials

A heavily modified RPG Maker XP game project that makes the game play like a Pokémon game. Not a full project in itself; this repo is to be added into an existing RMXP game project.
Other
208 stars 398 forks source link

Fixed Grav Apple having the incorrect damage boost #179

Closed C-Ezra-M closed 2 years ago

C-Ezra-M commented 2 years ago

In the official games, Grav Apple has a damage boost of 1.5x under Gravity, not 2x. This has been fixed.

Source: Bulbapedia. However, I took this from the French version of the article, as Bulbapedia has some backend issues right now (opening most pages gives an HTTP 503 response, but BulbaTech is working on removing this issue).

La capacité [Force G] voit sa puissance augmentée de 50% sous Gravité, passant à 120.
|
V
The move [Grav Apple] has its power increased by 50% under Gravity, to 120.

Updated the comment above the class definition to account for this change.

C-Ezra-M commented 2 years ago

Also changed the class name to accommodate for this change.

C-Ezra-M commented 2 years ago

Bulbapedia article on Grav Apple. Bulbapedia's backend issues have been fixed.

Posted this message just for the permalink.

Maruno17 commented 2 years ago

The function code "LowerTargetDefense1DoublePowerInGravity" is referenced in an AI script. Can you change that as well to the new name "LowerTargetDefense1PowersUpInGravity"?

C-Ezra-M commented 2 years ago

Just fixed this (at first, I didn't notice the new name part). Also, is the change in how the multiplier is calculated because the power must be interpreted as an integer, not as a float?

Maruno17 commented 2 years ago

I suspect it doesn't matter if the base damage is a float, but multiplying it by 3/2 is at least consistent with, say, "HitsAllFoesAndPowersUpInPsychicTerrain". The change of Grav Apple's function code name is also to make it consistent with this function code.