search

Maruno17 / pokemon-essentials

A heavily modified RPG Maker XP game project that makes the game play like a Pokémon game. Not a full project in itself; this repo is to be added into an existing RMXP game project.
Other
208 stars 398 forks source link

Battle Point Shop additions #190

Closed supersand24 closed 1 year ago

Maruno17 commented 2 years ago

In Compiler_WritePBS, you're making the BP price be written no matter what. This means every single item will have a BP price written into items.txt, even though the vast majority have no business being purchasable for BP. I do like that the default price is 1 rather than 0, though. I think you should only write the BP price into items.txt if it isn't 1.

You should probably make the BPPrice schema be "v" instead of "u", because there's literally no reason to allow a BP price of 0. The regular price can be 0 because that prevents the item being sold, but you can't sell anything for BP.

You've made the editor's description of BPPrice be "Purchase price of this item, in Exchange Service Corner.", but it'd be more accurate if it said "Purchase price of this item in Battle Points (BP).". We don't know what the name of the BP shop is going to be in someone's game.

Be careful with the indentations in the BP Shop script file. Also, are the messages in there accurate to what they are in the official games?

There's also a conflict now that needs resolving.

supersand24 commented 2 years ago

I was making some of the changes you recommended.

The messages in the UI_BattlePointShop mostly come from Gens 3-5. They seem to have dropped the "Exchange Service Corner" name after that, however Bulbapedia appears to keep the name up to Gen 7.

Still working on the Pull Request though, should be done by today.

Maruno17 commented 2 years ago

You've given BP prices to a lot of items in the PBS files, more than I would have thought were available for purchase with BP. For example, what made you decide that the Master Ball was worth 48 BP, or the Reveal Glass was worth 48 BP? I've only skimmed through the Gen 5 items.txt so far, but this looks like a problem.

Is there a way to rebase your edits on top of the updated copy of Essentials, rather than including all of the unrelated edits to Essentials in this pull request?