Maruno17 / pokemon-essentials

A heavily modified RPG Maker XP game project that makes the game play like a Pokémon game. Not a full project in itself; this repo is to be added into an existing RMXP game project.
Other
208 stars 398 forks source link

Gen 9 Ability and Move PBS #207

Closed futuresushi closed 4 months ago

futuresushi commented 1 year ago

These commits

  1. Define the new Abilities and their descriptions into the abilities.txt file, in the main series index order, as well as gives them Ability Descriptions that fit into the standard Essentials Ability Description fields (which are pretty small!). Of these, Anger Shell, Purifying Salt and Thermal Exchange likely require some fine-tuning.

    1. "a powerful boost" might be too vague but you can maybe fit one more word in there
    2. I feel like "protection" implies an immunity, but it's hard to fit more words to give them separate clauses
    3. Doesn't mention Burn immunity, and Water Bubble does, but Water Bubble also doesn't mention its Water-move boosting effect, so it's PROBABLY fine?
  2. Define the new Moves, all their attributes and their flags into the moves.txt file, in order of Type then Descending Power then Name. Give Ability descriptions that fit into the standard Essentials Move Description box. Of these, only Triple Arrows has to compromise on full content, omitting its high crit chance for space. For moves whose FunctionCode can match older moves, use that Function Code, otherwise put a Placeholder.

  3. Change PBS entries for older moves to account for new attributes, such as the Wind and Slicing flags, and changed attributes, like drops in Power or PP. In cases where a move was "Snapped" by Game Freak and it did not gain new Flag entries despite being suitable, exercised some discretion applying them.

  4. Change description for two moves, Ally Switch and Charge, whose effects changed slightly. THE CODING WORK FOR THESE CHANGES HAVE NOT BEEN DONE IN THIS PR AS OF YET.

These edits do not account for work that would need to be done to actually code the new Abilities or Function Codes for moves, but rather exists to provide a PBS framework. Edits to those files could be continued on the branch for implementation of Gen 9 moves and Abilities.