A heavily modified RPG Maker XP game project that makes the game play like a Pokémon game. Not a full project in itself; this repo is to be added into an existing RMXP game project.
Other
208
stars
398
forks
source link
Fixed bug where follower sprites did not update correctly after exiting the terrain tag editor #221
This PR fixes the bug mentioned in the title. The issue is that if the player has a follower with them, then enters and exits the terrain tag editor from the Debug menu (even without making any edits), the follower sprite would start to move weirdly until the next map transfer (attached a gif below to demonstrate the issue).
The root cause of this issue is that after exiting the terrain tag editor, the game reloads all of the spritesets, including the current map. The follower sprites have an internal attribute @map that points to the current map object, but when the spritesets get reloaded, the current map object changes, so the follower sprites are still pointing to the old map object. This messes up the calculations used for the follower sprites' display coordinates as it relies on the old map's display coordinates instead of the new one.
This PR fixes this issue by simply refreshing the follower factory in between disposing the old spritesets and creating the new ones after exiting the terrain tag editor.
This PR fixes the bug mentioned in the title. The issue is that if the player has a follower with them, then enters and exits the terrain tag editor from the Debug menu (even without making any edits), the follower sprite would start to move weirdly until the next map transfer (attached a gif below to demonstrate the issue).
The root cause of this issue is that after exiting the terrain tag editor, the game reloads all of the spritesets, including the current map. The follower sprites have an internal attribute
@mapthat points to the current map object, but when the spritesets get reloaded, the current map object changes, so the follower sprites are still pointing to the old map object. This messes up the calculations used for the follower sprites' display coordinates as it relies on the old map's display coordinates instead of the new one. This PR fixes this issue by simply refreshing the follower factory in between disposing the old spritesets and creating the new ones after exiting the terrain tag editor.