search

Marus / cortex-debug

Visual Studio Code extension for enhancing debug capabilities for Cortex-M Microcontrollers
MIT License
1.02k stars 240 forks source link

Stop button does not close Debug toolbar #1044

Open SashaHalytska opened 2 months ago

SashaHalytska commented 2 months ago

Describe the bug type: Bug

I am using Cortex-Debug extension to debug Cortex-M based microcontroller's firmware: https://github.com/Marus/cortex-debug/tree/master Starting from the VSCode 1.86.2 I am observing an issue with the Stop button not closing the Debug toolbar. The issue reproducible only if the Restart button was pressed before Stop button.

This was not happening prior to 1.86.2.

The last version with which I see the issue 1.93.1

VS Code version: Code 1.93.1 OS version: All: Windows 11, Mac 14, Ubuntu 22

Expected behavior Debug toolbar with buttons doesn't exist

Actual Result: Debug toolbar with buttons exists, some of buttons even clickable It looks like this

Screenshots

![image] image

Environment (please complete the following information):

diggit commented 5 days ago

Yes, this is happening on all my machines (ArchLinux, WSL, Windows) for several months and it's a annoying. It's difficult to start the new debug session afterwards. In my case, this happens when I restart the target at least once. If I never use restart button, I am usually fine. It looks like vscode itself thinks, debug session is still active, but cortex debug already stopped GSB server and GDB itself.

haneefdm commented 5 days ago

@SashaHalytska, are you building cortex-debug from source? I ask because you have a link to our repo. I don't know when I will get a chance to release this --- there are other changes being tested.

In the unreleased version sitting in our repo is a fix/workaround for the Restart button.

See also #1029