#18 Add validation of custom grok patterns file

Marusyk / grok.net

.NET implementation of the grok 📝

MIT License

287 stars 55 forks source link

#18 Add validation of custom grok patterns file #24

Closed MazixM closed 3 years ago

MazixM commented 3 years ago

This is checking if content of custom grok patterns and also grok-patterns are correct on loading.

Marusyk commented 3 years ago

Please add unit tests

MazixM commented 3 years ago

If i add this then i can help users to find bug if they done some mistake in a file. I can add for example ArgumentException in case of not valid file. Can you let me know is it good way?

Marusyk commented 3 years ago

Yeah, agree. I think you can use FormatException for that

Marusyk commented 3 years ago

Hi @MazixM I am sorry but the issue has already been fixed in this PR #23 Thank you for your interest in this project. If you have some ideas on how to make grok.net better, please don't hesitate - create a PR.

Also, we will keep a list of issues that are approachable for newcomers under the good-first-issue label.

Waiting for your new PRs