Add Unit Tests to improve Code Coverage

Marusyk / grok.net

.NET implementation of the grok 📝

MIT License

290 stars 55 forks source link

Add Unit Tests to improve Code Coverage #41

Closed Marusyk closed 2 years ago

Marusyk commented 3 years ago

Now it is

Let's improve that

marce1994 commented 3 years ago

Can I take this one? 😄

Marusyk commented 3 years ago

@marce1994 sure, it is yours

marce1994 commented 3 years ago

@Marusyk It's a little bit difficult, I don't know how to pass through the untested parts of the code :( Untested code: Grok.cs lines: 91 to 109, 139(untestable), 163, 209.

Edit: I'll continue today night.

Marusyk commented 3 years ago

hi @marce1994 it is ok if you cannot cover some lines. Our goal is to increase the coverage percentage, it doesn't have to be 100

marce1994 commented 3 years ago

I don't know if it's an issue, but the float type converts to double. It is fine? @Marusyk

marce1994 commented 3 years ago

hi @marce1994 it is ok if you cannot cover some lines. Our goal is to increase the coverage percentage, it doesn't have to be 100

Done I think :)

Thx!

Marusyk commented 3 years ago

Now it is 96%!

Can anyone improve it more?

eddami commented 2 years ago

Code coverage went down to 65% after we added the PowerShell module. I will write unit tests for it.

Marusyk commented 2 years ago

Not it is

Marusyk commented 2 years ago

Now it is

I'm going to close the issue for now :)