search

Marusyk / grok.net

.NET implementation of the grok 📝
MIT License
290 stars 55 forks source link

Using EditorConfig-Action #54

Closed Marusyk closed 2 years ago

Marusyk commented 2 years ago

Extend workflow with: https://github.com/zbeekman/EditorConfig-Action

jatingandhimaersk commented 2 years ago

Where is the issue mentioned?

Marusyk commented 2 years ago

Hi @jatingandhimaersk what do you mean?

DASchechtman commented 2 years ago

So what exactly are you asking for here?

Marusyk commented 2 years ago

Integrate EditorConfig-Action into workflows

Add a new editorconfig action that will run on every PR

DASchechtman commented 2 years ago

ok I see. another question. how do I build this project so I can make changes? I tried to build and ran into a lot of errors

Marusyk commented 2 years ago

What kind of errors? Do you mean builds.yml?

DASchechtman commented 2 years ago

This is what I mean by errors.

image
Marusyk commented 2 years ago

emmm... this is not a build error. image

please take a closer look at the error message. it says that you cannot run (F5) the project because it is a class library (nuget package)

did you try to google this error?

DASchechtman commented 2 years ago

I did try to google it and couldn't find a way to resolve it. And I came to the conclusion that I need to run this from another program. However, I do not know how to import this into another project. I admit maybe build error was the wrong description. My main problem is I don't know how to get the project running so I can make changes and test them. What would your process be for getting this project up and running.

Marusyk commented 2 years ago

It seems you don't familiar with .NET ecosystem very well. I would recommend you to learn more about .NET, gain practical experience, and then come back to this task. Good luck

DASchechtman commented 2 years ago

I was able to get it running by running the test files. But thanks for the help anyway

FarzamMohammadi commented 2 years ago

Hey @DASchechtman, the issue is that you need to set the startup project first. That is why you were not able to run it. Check out the second solution mentioned here: https://stackoverflow.com/questions/3363106/a-project-with-an-output-type-of-class-library-cannot-be-started-directly

@Marusyk May I take a stab at this this issue?

Marusyk commented 2 years ago

hi @FarzamMohammadi sure, go-ahead

FarzamMohammadi commented 2 years ago

Okay here it is: https://github.com/Marusyk/grok.net/pull/57 any feedback/suggestions?

Marusyk commented 2 years ago

great, could you show us screen with result?