search

Marusyk / grok.net

.NET implementation of the grok 📝
MIT License
290 stars 55 forks source link

update shell #59

Closed ragu-1997 closed 2 years ago

ragu-1997 commented 2 years ago

Add procedural shell format

Marusyk commented 2 years ago

Hi, what does it mean?

(good-first-issue-(good-first-issue)

ragu-1997 commented 2 years ago

Hi, Sorry unfortunately i mentioned a label

On Tue, Oct 11, 2022, 3:06 AM Roman Marusyk @.***> wrote:

Hi, what does it mean?

(good-first-issue-(good-first-issue)

— Reply to this email directly, view it on GitHub https://github.com/Marusyk/grok.net/pull/59#issuecomment-1273840883, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATLYDUJRPZGU74IC5A25KXDWCSD4TANCNFSM6AAAAAARBAU5EU . You are receiving this because you authored the thread.Message ID: @.***>

ragu-1997 commented 2 years ago

Ok, I will check.

On Thu, Oct 13, 2022, 1:02 AM Roman Marusyk @.***> wrote:

@.**** requested changes on this pull request.

Please fix the editorconfig warning

— Reply to this email directly, view it on GitHub https://github.com/Marusyk/grok.net/pull/59#pullrequestreview-1139614958, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATLYDUJVARAYONPMHOAMMPLWC4G33ANCNFSM6AAAAAARBAU5EU . You are receiving this because you were mentioned.Message ID: @.***>

ragu-1997 commented 2 years ago

Ok, I will check. … On Thu, Oct 13, 2022, 1:02 AM Roman Marusyk @.> wrote: @*.*** requested changes on this pull request. Please fix the editorconfig warning — Reply to this email directly, view it on GitHub <#59 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATLYDUJVARAYONPMHOAMMPLWC4G33ANCNFSM6AAAAAARBAU5EU . You are receiving this because you were mentioned.Message ID: @.>

ragu-1997 commented 2 years ago

Field Names Must Not Begin With Underscore in the .editorconfig. Along with the attribute you documented, it would be helpful if how to setup it up in the .editorconfig file.

ragu-1997 commented 2 years ago

Please approved the request I'll mention some points

On Thu, Oct 13, 2022, 12:58 AM Roman Marusyk @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/Marusyk/grok.net/pull/59#pullrequestreview-1139610943, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATLYDUPBPTMNRIUZ4KLTN2TWC4GNJANCNFSM6AAAAAARBAU5EU . You are receiving this because you authored the thread.Message ID: @.***>