search

MarvNC / JP-Resources

My contributions to the Japanese learning community.
MIT License
88 stars 4 forks source link

Script to backfill FrequenciesStylized in JP Mining Note #18

Closed arbyste closed 1 year ago

arbyste commented 1 year ago

This pull request adds a python script for backfilling the FrequenciesStylized field in JP Mining Note, updates the README to include instructions on its use, and adds all supporting files for this functionality.

Instructions on how to use the script can be found in the README.

I think everything is ready to go, but I could use another set of eyes on it. In particular, does the documentation make sense to someone unfamiliar with the script? I'm on Linux, so it would be helpful if someone can confirm that the instructions work on Windows as well.

Let me know if there are any changes you'd like me to make.

MarvNC commented 1 year ago

Looks good to me, though I'm wondering if it might be better as a section in the JPMN docs given its specificity to that project. Though given that Aquafina is currently inactive, I'd be happy to merge this in the meantime.