search

MarvellEmbeddedProcessors / mv-ddr-marvell

18 stars 23 forks source link

ported changes from globalscaletechnologies for EspressoBin #24

Closed heaterC closed 3 years ago

heaterC commented 3 years ago

These changes ported from Globalscaletechnologies seem to be vital for EspressoBin v7 DDR4 1GB 1cs.

pali commented 3 years ago

Hello! Development branch is mv-ddr-devel. Could you rebase it on top of this branch? mv_ddr-armada-18.12 is old and is not updated since 22 Nov 2018.

heaterC commented 3 years ago

Ok. They both didn't look recent to me! ;-)

pali commented 3 years ago

mv-ddr-devel was updated in Jun 25, 2020, which is recent :-)

heaterC commented 3 years ago

I had a look at the changes from Globalscale and they seem to interfere with changes from 18.12 to devel. Unfortunately, I lack the knowledge to merge the correct changes into the devel branch.

I already asked the guys at Globalscale to PR their changes at the Marvell repo but did not get a reply so far.

I am sorry I am no help at this point, since I am not an embedded developer and can only fulfill organisational tasks.

pali commented 3 years ago

So pickup changes manually from their repo, same changes which you did for branch old mv_ddr-armada-18.12.

pali commented 3 years ago

@heaterC: Could you please just cherry-pick changes which are needed for DDR4 1GB 1cs and rebase them on top of mv-ddr-devel branch?

heaterC commented 3 years ago

I am sorry I will try as soon as I can find some time. :-(

pali commented 3 years ago

also do not forget to change base branch of this pull request to mv-ddr-devel via Edit button near pull request title.

heaterC commented 3 years ago

These patches seem all to be applied already in branch mv-ddr-marvell.

pali commented 3 years ago

Are there really all patches? If yes, then you do not have to do anything else :-)