MarvellEmbeddedProcessors / u-boot-marvell

Marvell PBU U-Boot
Other
65 stars 74 forks source link

efi_loader: fix building crt0 with binutils 2.30+ #16

Open berolinux opened 6 years ago

berolinux commented 6 years ago

Before the patch an undefined constant EFI_SUBSYSTEM was used in the crt0 code. The current version of binutils does not swallow the error.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888403

The necessary constant IMAGE_SUBSYSTEM_EFI_APPLICATION is already defined in pe.h. So let's factor out asm-generic/pe.h for the image subsystem constants and use it in our assembler code.

IMAGE_SUBSYSTEM_SAL_RUNTIME_DRIVER does not exist in the specification let's use IMAGE_SUBSYSTEM_EFI_ROM instead.

The include pe.h is only used in code maintained by Alex so let him be the maintainer here too.

Author: Heinrich Schuchardt xypron.glpk@gmx.de Reported-by: Andre Przywara andre.przywara@arm.com Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de Tested-by: Vagrant Cascadian vagrant@debian.org Signed-off-by: Alexander Graf agraf@suse.de [bero@lindev.ch: Backported from u-boot master to marvell 18.06 tree] Signed-off-by: Bernhard Rosenkränzer bero@lindev.ch Tested-by: Bernhard Rosenkränzer bero@lindev.ch