search

MarvellousSoft / MarvInc

Zachlike with an immersive storyline told through emails.
https://marvellous.itch.io/marvellous-inc
GNU General Public License v3.0
55 stars 7 forks source link

Make text pasting more user-friendly #240

Closed ghost closed 6 years ago

ghost commented 6 years ago

This is one possible fix for #226. Note there are more callers to typeString, so those need to be checked. In particular, I've noticed that one side effect of this patch is that when using undo on a puzzle you've just opened which you already worked on, the whole text is removed at once now (as opposed to undoing one character at a time, which is how it works without the patch). I don't think that's a significant change, though. It may be considered an issue that undo works in that situation, in the first place (editors usually don't allow undo right after opening an existing file), but it's one that doesn't bother me.

rilifon commented 6 years ago

I requested review from our dev that spent the most time on that code. If he doesn't respond or have the time, I'll review this PR myself. Thanks again for this PR, we'll include your fix and a special thanks in the game credits on your behalf ^^

yancouto commented 6 years ago

Thank you :D. I merged it, after fixing some behavior.

ghost commented 6 years ago

Thanks for merging, and good catch on the manual edits! And no worries about the delay. I have some PRs waiting for months in a certain project, and not for lack of dev interest, but for lack of dev time.