MarvellousSoft / MarvInc

Zachlike with an immersive storyline told through emails.
https://marvellous.itch.io/marvellous-inc
GNU General Public License v3.0
55 stars 7 forks source link

Add initial flatpak build support #268

Closed joshua-stone closed 4 years ago

joshua-stone commented 4 years ago

This PR adds supports for flatpak as a distribution method. There are numerous advantages of flatpak, such as:

It's possible to distribute flatpak'd apps on a centralized repository like Flathub, but in the case of MarvInc I think it's best to set it up as a bundle which can be then shipped to itch.io:

[jstone@joshua-laptop MarvInc]$ cd dist/flatpak
[jstone@joshua-laptop flatpak]$ ./flatpak-build.sh io.itch.marvellous-inc
[jstone@joshua-laptop flatpak]$ ls -lh io.itch.marvellous-inc.flatpak 
-rw-r--r--. 1 jstone jstone 40M Oct 16 21:45 io.itch.marvellous-inc.flatpak
[jstone@joshua-laptop flatpak]$ flatpak install --user --assumeyes io.itch.marvellous-inc.flatpak

Support can be wired up to deploy.sh if there's interest in upstreaming this.

RenatoGeh commented 4 years ago

Thank you for the PR. I like the idea of getting MarvInc to flatpak.

Yeah, my only complaint is flatpak-build.sh as a separate script, which you already mentioned. I'll be more than happy to merge this PR if you set this as a deploy.sh build flag.

joshua-stone commented 4 years ago

@RenatoGeh I've refactored flatpak distribution to be part of deploy.sh. Is there anything else that has to be done?

joshua-stone commented 4 years ago

@RenatoGeh @rilifon More commits have been made to improve the flatpak build target. How does everything look now?

RenatoGeh commented 4 years ago

LGTM. Tested flatpak build and came out fine. Merging this. Many thanks for the PR.