Bump SonarAnalyzer.CSharp from 9.3.0.71466 to 9.4.0.72892

[dependabot[bot]]

Bumps SonarAnalyzer.CSharp from 9.3.0.71466 to 9.4.0.72892.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

9.4

Release 9.4 brings one new rule for C# and four new rules for VB.NET. It also brings improvements by migrating two more rules to the new symbolic execution engine, fixing false positives, and improving memory allocation.

Thanks to @​sharwell for his contribution by reporting 7438. Thanks to @​Corniel for his contribution by implementing new rule S2925 in 7342.

New Rules

• 7305 - [VB.NET] New rule S3966: Objects should not be disposed more than once
• 7304 - [VB.NET] New rule S1944: Invalid casts should not be made
• 7303 - [VB.NET] New rule S4158: Empty collections should not be accessed or iterated
• 7342 - [C#, VB.NET] New Rule: S2925 Do not use Thread.Sleep() in a test

Improvements

• 7302 - [C#] Migrate S3966 to the new Symbolic Execution engine
• 7300 - [C#] Migrate S4158 to the new Symbolic Execution engine
• 7301 - [C#] Improve S1944: Rule now detects more issues
• 7322 - [C#] Symbolic Execution: Learn NotNull from ??= for nullable types
• 7267 - [C#, VB.NET] Symbolic Execution: Add BinaryOperation for literals: division, remainder, xor
• 7435 - [C#] Improve S4635: Update issue message
• 7365 - [C#] Improve S2198: Update issue message
• 7337 - Update RSPEC before 9.4 release

False Positives

• 4261 - [C#] Fix S4158 FP: When a collection was filled by using delegates
• 2147 - [C#] Fix S4158 FP: Variable instance mismatch
• 7308 - [C#] Fix S3655 FP: Recognize ??= for nullable types
• 6179 - [C#, VB.NET] Fix S4158 FP: When the collection was filled during for loops, was reported to be empty

Performance

• 7438 - Memory allocation improvement: HasMatchingScope should not allocate a new delegate on every call

Commits

• eefdd88 Update RSPEC before 9.4 release (#7460)
• 6cde32d Update message of S4635 (#7435)
• b6ce681 Migrate S4158: Do not report on method references (#7453)
• 6dceab4 Migrate S4158: Passing as argument removes constraint (#7433)
• 897430c Migrate S4158: Support Dictionary Setter (#7418)
• 5d2ab8e Migrate S3699: Implement ShouldExecute for VB.NET (#7449)
• 7546630 Update NuGet.Packaging to 6.6.1 (#7456)
• b00af07 Migrate S4158: Support Enumerable.Count extension (#7452)
• 95cd5d8 Update RSPECs as part of the LayC migration (sixth batch) (#7454)
• ecb72c6 S4158 FP: Collection filled in a for loop reported to be empty (#7447)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[Marvin-Brouwer]

@dependabot recreate

[dependabot[bot]]

Superseded by #323.