MarvinJWendt / testza

Full-featured test framework for Go! Assertions, fuzzing, input testing, output capturing, and much more! 🍕
MIT License
418 stars 21 forks source link

ci: use fixed version of go for linting #109

Closed jamestelfer closed 2 years ago

jamestelfer commented 2 years ago

The v3 action doesn't attempt to set up go, allowing the version already set to be used. This fixes an issue where the linter throws a pile of issues like:

  Error: undeclared name: `FuzzInputSdtringGenerateRandom` (typecheck)
  Error: undeclared name: `AssertEqual` (typecheck)
  Error: undeclared name: `AssertEqualValues` (typecheck)
  Error: undeclared name: `AssertKindOf` (typecheck)
  Error: undeclared name: `AssertTestFails` (typecheck)

An alternative is to set golangci-lint to target 1.18, but this disables a lot of checks.

codecov[bot] commented 2 years ago

Codecov Report

Merging #109 (dfcd021) into main (77ba3a4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          10       10           
  Lines         658      658           
=======================================
  Hits          581      581           
  Misses         40       40           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77ba3a4...dfcd021. Read the comment docs.

MarvinJWendt commented 2 years ago

Thanks!