Closed atlekbai closed 1 year ago
I don't understand how anything works
On Tue, 4 Oct 2022, 17:54 Tlekbai Ali, @.***> wrote:
@.**** commented on this pull request.
In configuration.go https://github.com/MarvinJWendt/testza/pull/182#discussion_r987125095:
- initSync.Lock()
- defer initSync.Unlock()
Hello! I am using the locks, since the value can be changed on runtime. Basically, I was orienting on the setters, since they were using locks too.
— Reply to this email directly, view it on GitHub https://github.com/MarvinJWendt/testza/pull/182#discussion_r987125095, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3IN4NKXZH2KTSDBPHGHAEDWBROKPANCNFSM6AAAAAAQ4WNFOQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Base: 86.84% // Head: 87.02% // Increases project coverage by +0.17%
:tada:
Coverage data is based on head (
e2913c8
) compared to base (b2fec78
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@MarvinJWendt waiting for the review :)
Added getters for settings in
configuration.go
:closes #111