MarvinJWendt / testza

Full-featured test framework for Go! Assertions, fuzzing, input testing, output capturing, and much more! 🍕
MIT License
418 stars 21 forks source link

Add getters for setters in configuration.go #182

Closed atlekbai closed 1 year ago

atlekbai commented 1 year ago

Added getters for settings in configuration.go:

func GetColorsEnabled() bool
func GetLineNumbersEnabled() bool
func GetRandomSeed() int64
func GetShowStartupMessage() bool
func GetDiffContextLines() int

closes #111

danieltiman666 commented 1 year ago

I don't understand how anything works

On Tue, 4 Oct 2022, 17:54 Tlekbai Ali, @.***> wrote:

@.**** commented on this pull request.

In configuration.go https://github.com/MarvinJWendt/testza/pull/182#discussion_r987125095:

  • initSync.Lock()
  • defer initSync.Unlock()

Hello! I am using the locks, since the value can be changed on runtime. Basically, I was orienting on the setters, since they were using locks too.

— Reply to this email directly, view it on GitHub https://github.com/MarvinJWendt/testza/pull/182#discussion_r987125095, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3IN4NKXZH2KTSDBPHGHAEDWBROKPANCNFSM6AAAAAAQ4WNFOQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

codecov[bot] commented 1 year ago

Codecov Report

Base: 86.84% // Head: 87.02% // Increases project coverage by +0.17% :tada:

Coverage data is based on head (e2913c8) compared to base (b2fec78). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #182 +/- ## ========================================== + Coverage 86.84% 87.02% +0.17% ========================================== Files 10 10 Lines 730 740 +10 ========================================== + Hits 634 644 +10 Misses 58 58 Partials 38 38 ``` | [Impacted Files](https://codecov.io/gh/MarvinJWendt/testza/pull/182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marvin+Wendt) | Coverage Δ | | |---|---|---| | [configuration.go](https://codecov.io/gh/MarvinJWendt/testza/pull/182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marvin+Wendt#diff-Y29uZmlndXJhdGlvbi5nbw==) | `74.35% <100.00%> (+3.77%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marvin+Wendt). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marvin+Wendt)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

atlekbai commented 1 year ago

@MarvinJWendt waiting for the review :)