search

MarvinKlein1508 / SignaturePad

A simple to use blazor component to draw custom signatures.
MIT License
72 stars 12 forks source link

Performance and Acuraccy Improvements #35

Closed CodeGod911 closed 3 days ago

CodeGod911 commented 3 days ago

capture lines below 6 points for fast short lines render only while drawing

CodeGod911 commented 3 days ago

This is related to the point i mentioned because of the event, constant drawing and a bug i found Edit: The bug prevented perfect dots and drawed only dots for too fast lines with less than 6 points

MarvinKlein1508 commented 3 days ago

This seems to fix the displaying of pre existing signatures, however once you draw anything the preexisting signature will be overwritten. Related to #30

CodeGod911 commented 3 days ago

ill look into it dont know exactly. did u put it as background image before?

MarvinKlein1508 commented 3 days ago

Ok. I've remove the canvas clearing. Otherwise it will be impossible to change an existing signature. Also it would break the background-image feature. Performance wise I don't run into any issues but I've got a quite powerful PC. Works fine for me in Firefox, Edge & Safari on mobile.

CodeGod911 commented 3 days ago

ill check if frame time changes after big drawings too be sure

CodeGod911 commented 3 days ago

Times seem to be very consistent between. Edit: (0.13ms - 0.34 ms on my pc with redrawing every frame not only when drawing)

MarvinKlein1508 commented 3 days ago

Should work fine now in v8.1.2