search

Marwes / combine

A parser combinator library for Rust
https://docs.rs/combine/*/combine/
MIT License
1.3k stars 94 forks source link

Apply cargo clippy and cargo fmt #300

Closed Byron closed 4 years ago

Byron commented 4 years ago

What's missing is running these on CI, which I refrained from doing in this PR to not conflate things.

Byron commented 4 years ago

It looks like CI fails as cargo doc is run with rust 1.40. Recently clippy started to suggest the matches!() macro, which is available in 1.42 and above.

Would you like me to remove usages of the matches!() macro, or rather allow docs to be generated with rustc 1.42?

Marwes commented 4 years ago

Might be easiest to remove the use of matches!, rather than adjusting ci to skip doctests on 1.40. Either way works for me though!

Byron commented 4 years ago

Alright! I think if travis runs the .travis.yaml from the PR, it should work next time with upping the minimal version used to 1.42 . I really like matches!() and am glad clippy now informs about it - wasn't aware of it's existence at all till now.

Marwes commented 4 years ago

Thanks!