search

Marzona / rig-remote

remote control a rig through rigctl protocol
MIT License
21 stars 6 forks source link

rig-remote gets stuck after a scanning task has completed #30

Closed Marzona closed 8 years ago

Marzona commented 8 years ago

when a scanning task completes, the stop button doesn't change to start and pressing the stop button doesn't produce any result, doesn't commute it to start and the program is blocked. The only way out is killing the python interpreter process.

Marzona commented 8 years ago

one behavior is fixedin devel/6c7b2fc6e8d8eed0565cf41369b5b69748f3f2cc

MaineTim commented 8 years ago

One error is that scanning.py Line 259 task.new_bookmark_list.append(nbm) needs to be indented.

Marzona commented 8 years ago

Yes found it, that's fixed

Simone Marzona

Linux registered user number: 509183

PGP key ID: 1024D/36F88CC3

Star Trek (2009):

Burly Cadet #1: Hey farmboy. Maybe you can't count. But there are four of us and one of you. James T. Kirk: So get some more guys and then it'll be an even fight On Apr 17, 2016 10:03, "MaineTim" notifications@github.com wrote:

One error is that Line 259 task.new_bookmark_list.append(nbm) needs to be indented.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/Marzona/rig-remote/issues/30#issuecomment-210982842

MaineTim commented 8 years ago

So it's failing in the call to task.stop_scan_button.event_generate(""). That method did work when I wrote it a while back, but a lot has changed since then, and frankly I neglected to to check it recently as I haven't had a need for limited passes. Probably I just got lucky in not running into tkinter thread issues initially.

Marzona commented 8 years ago

No worries, I'm checking. I'll update the issue.

Regards

Simone Marzona

Linux registered user number: 509183

PGP key ID: 1024D/36F88CC3

Star Trek (2009):

Burly Cadet #1: Hey farmboy. Maybe you can't count. But there are four of us and one of you. James T. Kirk: So get some more guys and then it'll be an even fight On Apr 17, 2016 11:09, "MaineTim" notifications@github.com wrote:

So it's failing in the call to task.stop_scan_button.event_generate(""). That method did work when I wrote it a while back, but a lot has changed since then, and frankly I neglected to to check it recently as I haven't had a need for limited passes. Probably I just got lucky in not running into tkinter thread issues initially.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/Marzona/rig-remote/issues/30#issuecomment-210990739

Marzona commented 8 years ago

Fixing this issue implies refactoring part of the code that covers the end of the task.

As discussed this is the way we want to go:

MaineTim commented 8 years ago

GUI code removed from scan thread and thread comms using STMessenger class in tim_devel_fix_issue30.