search

Masaiki / xy-VSFilter

xy-VSFilter variant with libass backend
https://github.com/Masaiki/xy-VSFilter
GNU General Public License v2.0
543 stars 10 forks source link

Position effects bounce in and out of place #11

Closed JustNoon closed 2 years ago

JustNoon commented 2 years ago

I don't know what I'm doing or saying so I'm just including as many details as I can think of.

Subtitle position doesn't seem to be set correctly each frame. It is correctly set in mpv or the legacy xy-VSFilter implementation.

Can be convinced to play correctly by

  1. Applying "Use VSFilter (legacy) ASS implementation"
  2. Playing at least a frame of video (will render blank otherwise)
  3. Seeking backwards to a frame that contains the position effect (citation needed on which exact effect)
  4. Unapplying it This corrects the problem completely until the video is reloaded.

xy-VSFilter with libass image

xy-VSFilter image

mpv image

{\pos(550.2,841.39)\org(518.6,1025.9)\fscy120\frz-8.67\fry0.89\frx2.78\fnColored Crayons\fs45\c&HA1AFB0&\blur1.5\b}Anime Society\NSpecial Screening

[GJM] Eizouken ni wa Te wo Dasu na! - 01 [E3DDFF5F].mkv 07:16.87 MPC-HC 1.9.7 madVR 0.92.17 XySubFilter with libass version 20220831

Masaiki commented 2 years ago

i can't reproduce it using mpc-be 1.6.4 / mpc-hc 1.9.23 / mpc-hc 1.9.7 + mpcvr/madVR + XySubFilter with libass version 20220831

JustNoon commented 2 years ago

It working for you made me believe it must be a setting so I investigated after updating to mpc-hc 1.9.23

I've learned that Allow video renderer to reposition simple SSA/ASS subtiles being checked causes the issue for me. Unchecking it fixes it completely as far as I can tell.

Whether the difference between checked and unchecked is a bug that warranted this issue being open is left to your discretion I suppose. I'm not entirely sure the intended behavior of the checkbox anyways but for my purposes, the issue is as good as fixed.

Thanks for your help!

Masaiki commented 2 years ago

it might be a madVR setting process.zoom control.move subtitles -> to bottom of the screen/window

JustNoon commented 2 years ago

You're definitely right. Unchecking that fixes it. The culprit has been found!

Masaiki commented 1 year ago

fixed by https://github.com/Masaiki/xy-VSFilter/commit/039503ea8862998c30b0ed1c30ec3bfb6afa06f0