Masaiki / xy-VSFilter

xy-VSFilter variant with libass backend
https://github.com/Masaiki/xy-VSFilter
GNU General Public License v2.0
543 stars 10 forks source link

Discuss: how to best signal this isn't actual xy-VSFilter #9

Closed TheOneric closed 2 years ago

TheOneric commented 2 years ago

I recall encountering several instances where bug reporters, confused or improperly labeled "xy-VSFIler/SUbFilter with libass" as plain "xy-VSFilter/SubFilter" (though without taking a closer look again I can only refer to one report immediately). So, I was wondering if it’d be possible to make it even more obvious that what can be found here is only using the VSFIlter/SubFilter interface but a completely different (unfortunately) not (yet) fully compatible implementation. Currently, README.md and the Release notes already mention that this is “with libass”, but perhaps this and its meaning could be conveyed even more prominently. I was thinking of some or all of the following, though different approach certainly can work too:

It’s possible it’s already plenty clear enough and the reporters just forgot about this not being actual xy-VSFilter some time after downloading, but I figured it is worth to at least ask.

Masaiki commented 2 years ago

I basically agree with the first two proposals, and regarding the third proposal, I will consider it when more changes are made to the project.

TheOneric commented 2 years ago

Thanks, the changes made should (hopefully) help clear things up! Imho it would also be good to edit the text of the last release on GitHub, to ensure people who are directly navigating to https://github.com/Masaiki/xy-VSFilter/releases/latest also get to see an explicit note about xy-VSFilter incompatibility. I’m thinking even something short like e.g. the following should do:    “Note: This uses libass to render ASS and SSA, so the rendering of those is not compatible with original xy-VSFilter!”


EDIT: the new release's description now has such a notice, thanks!