Mascarada / epgp

Automatically exported from code.google.com/p/epgp
0 stars 0 forks source link

Change of coefficient producing 999 GP instead of 1000 GP. #669

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I was under the impression the new version of EPGP 5.5.23 would make ilevel 359 
chests equal 1000 Gear Points, however they equal 999 instead. Did the math not 
allow it to round out this number?

+ Load Game with EPGP 5.5.23
+ Check the Tooltip for GP of an ilevel 359 Chest

What is the expected output? What do you see instead?

+ Expected: 1000 Gear Points, Got: 999 Gear Points

What version of the product are you using? What locale is your client (en,
ru, kr, ch, es, tw)? What other addons do you have installed and what
versions? How many members do you have in your guild? (/guildinfo).

+ 5.5.23, EN, No other addons, 252 members.

Paste the text surrounded by -EPGP- in Guild Information here:

-EPGP-
@DECAY_P:10
@EXTRAS_P:100
@MIN_EP:500
@BASE_GP:100
-EPGP-

Source:

http://code.google.com/p/epgp/source/diff?spec=svn97b71e1fd766c9097ca941f47ce24e
73beef2425&r=97b71e1fd766c9097ca941f47ce24e73beef2425&format=side&path=/LibGearP
oints-1.0.lua

Original issue reported on code.google.com by dont.spa...@gmail.com on 17 Dec 2010 at 3:07

GoogleCodeExporter commented 8 years ago
Does it make a difference? 999 is cool :-D

Original comment by evlogimenos on 17 Dec 2010 at 4:27

GoogleCodeExporter commented 8 years ago
It just makes things easier to track if they were rounded out! :p 

The comment right above the equation in LibGearPoints-1.0.lua says it should 
equal out 1000.

-- 0.06973 is our coefficient so that ilvl 359 chests cost exactly 1000gp

Trying to do the math now and see what it should be to equal out 1000gp.

Original comment by dont.spa...@gmail.com on 17 Dec 2010 at 5:11

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
0.06974 seems to make everything even out to rounded numbers. Chests calculated 
to 1000 in-game now instead of 999, belts are now calculated in-game as 750 
instead of 749, etc.. :D 

Please correct me if I'm wrong!

Original comment by dont.spa...@gmail.com on 17 Dec 2010 at 5:21

GoogleCodeExporter commented 8 years ago
Not sure how you go about making changes to the final product, I'll upload a 
file just in case!

Original comment by dont.spa...@gmail.com on 17 Dec 2010 at 5:27

Attachments:

GoogleCodeExporter commented 8 years ago
999 will do me fine, I don't need shiny even numbers to be happy.

Original comment by dingochavezz@gmail.com on 18 Dec 2010 at 12:51

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Booo, I'm getting teamed up on! What's a girl to do? :p

I know it's not necessary for those of us without OCD, but it would be 
appreciated greatly! :D Please, it's just a change of a single digit in the 
calculation.

0.06973 changed to 0.06974 in LibGearPoints-1.0.lua for the next scheduled 
release! <3

Original comment by dont.spa...@gmail.com on 18 Dec 2010 at 1:13

GoogleCodeExporter commented 8 years ago
Wow, google freaked out and posted my comment a bunch of times. Hope I didn't 
spam anyone. >.<

Ironic considering my name, eh?

Original comment by dont.spa...@gmail.com on 18 Dec 2010 at 1:15

GoogleCodeExporter commented 8 years ago
The world does not revolve around people with OCD, if it did we would all be 
dead by now. What difference does it make really, 999 GP for a chest sounds OK 
to me, why should all the numbers end in a zero, to be pleasing to the eye. 
Mathematically, 999 is a much nicer number than 1000. Get over it.

Original comment by dingochavezz@gmail.com on 18 Dec 2010 at 9:01

GoogleCodeExporter commented 8 years ago
I tend to agree that It would be nice to have even numbers!

Original comment by chip.turner on 18 Dec 2010 at 9:16

GoogleCodeExporter commented 8 years ago
Thanks chip. Sounds like Dingo wants to make a big deal out of the change of a 
single digit. Some people just don't have anything better to feel superior 
about and irrationally want to flex the little power they have on the 
interwebs. 

I'll just change it myself. Thanks.

Original comment by dont.spa...@gmail.com on 18 Dec 2010 at 10:02

GoogleCodeExporter commented 8 years ago
People seem to forget that the people that developed and maintain these addons 
are also players. They also may have a RL's that will take up more of thier 
precious time instead of living and breathing WOW 24/7. If you (Dont.Spam.Meh) 
figured out what the calculation should be, go into the file and change it, and 
turn off automatic updates on this addon if you use Curse Client or any other 
automatic updater.  

I for one am greatful for the hard work people go through to develope and 
maintain addons to make the game easier to play and in the end more enjoyable.

Original comment by jdbus...@gmail.com on 18 Dec 2010 at 4:32

GoogleCodeExporter commented 8 years ago
This issue was closed by revision 371dd0fb6f.

Original comment by evlogimenos on 21 Dec 2010 at 12:51