search

Mascarada / epgp

Automatically exported from code.google.com/p/epgp
0 stars 0 forks source link

Shouldn't add GP to hidden tooltips #712

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
I've built an add-on that hooks LibGearPoints' GetValue function to change the 
gear point values for PvP items to zero. I'm using PlayerScore's 
TenTonHammer:GetItemRole function to determine which are PvP items, and 
PlayerScore in turn uses a hidden tooltip to access an item's stats. This at 
first crashed the game, and it took me a while to figure out the problem: EPGP 
had hooked the hidden tooltip's OnTooltipSetItem function to add GP to that 
tooltip, which was causing infinite recursion.

I fixed this by giving my function a file-local variable to check whether or 
not it was already running, but adding GP to hidden tooltips used by other 
add-ons is a waste of CPU cycles anyway. I'd suggest wrapping 
OnTooltipSetItem's body in:

if tooltip:IsVisible() then
  ...
end

Original issue reported on code.google.com by seahen...@gmail.com on 10 Sep 2011 at 1:56