search

Mascarada / epgp

Automatically exported from code.google.com/p/epgp
0 stars 0 forks source link

[IMPORTANT] Alt management broken on connected realms! #743

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
We are on Darkspear EU as a guild, which is now connected with Terokkar and 
Saurfang. This means that for us the players on those realms will be shown as 
Character-Terokkar. So we have Mainchar-Terokkar and Altchar-Terokkar. I add 
Mainchar-Terokkar in officer note of alt, and it is correctly marked as alt. Or 
well it is for people on Darkspear and Saurfang. However for people on Terokkar 
the main character is only named Mainchar without the -Terokkar because it's on 
the same realm.

What is the expected output? What do you see instead?
Match main character with both character and realmname.
This way i could add Mainchar-Darkspear to my Altchar-Darkspear and it will 
correctly mark it as an alt even tho i'm on Darkspear myself.

What version of the product are you using? What locale is your client (en,
ru, kr, ch, es, tw)? What other addons do you have installed and what
versions? How many members do you have in your guild? (/guildinfo).
v5.11.3
en (eu)
other addons doesn't matter
around 150 members.

Original issue reported on code.google.com by djricko0...@gmail.com on 4 Dec 2014 at 3:41

GoogleCodeExporter commented 8 years ago 
I am getting the same issue. I thought it didn't support servers but turns out 
it does. But on our own server I can't put that hence my officers from the 
shared server with mine can't see some alts

Original comment by dsvict...@gmail.com on 30 Jan 2015 at 12:04

GoogleCodeExporter commented 8 years ago 
My guild uses the addon and we are experiencing the same issues.

Original comment by kgood...@gmail.com on 5 Feb 2015 at 5:47

GoogleCodeExporter commented 8 years ago 
My guild is experiencing the same issue.

Original comment by kjsnyder...@gmail.com on 5 Feb 2015 at 5:49

GoogleCodeExporter commented 8 years ago 
Our guild is having same issue.

Original comment by clevermi...@gmail.com on 5 Feb 2015 at 5:50

GoogleCodeExporter commented 8 years ago 
Is this issue going to be addressed? I think it's a really important thing that 
will give troubles to raid leaders when running alts... Frankly it shouldn't be 
this long without being addressed

Original comment by dsvict...@gmail.com on 11 Feb 2015 at 5:29

GoogleCodeExporter commented 8 years ago 
I agree this would be nice to have working properly.  Patches are welcome; it 
isn't something my guild uses so I haven't had the need to fix it.  Cross-realm 
support is only partially functional (as you've seen); if someone wanted to 
champion fixing it, I would be very happy to help, but I won't likely get to it 
myself for quite a while.

Original comment by chip.turner on 24 Feb 2015 at 3:46

GoogleCodeExporter commented 8 years ago 
Could you tell me where the alt's relation to the main is being handled?

Original comment by dsvict...@gmail.com on 24 Feb 2015 at 3:52

GoogleCodeExporter commented 8 years ago 
Not offhand; it's in various places in different parts of the codebase.  If 
you're wanting to make a patch (yay!) then you're going to have to dive in and 
explore.  It (probably) isn't a one line fix, or, if it is, it's not a trivial 
line to find.

Original comment by chip.turner on 24 Feb 2015 at 3:54

GoogleCodeExporter commented 8 years ago 
Well it seems the roster fills without the server name when on the same server 
so maybe if we include the server name by force to same realm characters it 
should identify them from that point on since I assume the lookout is failing 
cause it looks for the string "name" instead of "name-server"

Original comment by dsvict...@gmail.com on 24 Feb 2015 at 3:56

GoogleCodeExporter commented 8 years ago 
Chip it seems that characters of the same realm are not being handled with 
their current server because on LibGuildStorage-1.2.lua line 316 the 
Ambiguate(name, "none") makes characters of the same realm not to show it. By 
changing to Ambiguate(name, "mail") when the addon loads it shows everyone's 
realm and the alts and everything seems to work fine. I do understand it might 
be annoying to see all realm names on the EPGP roster but I think with an extra 
setting to display or not when rendering the frames should be a nice addition 
if in anyone's interest. If there is anything wrong with this solution please 
do let me know

Original comment by dsvict...@gmail.com on 24 Feb 2015 at 5:53

GoogleCodeExporter commented 8 years ago 
So I found another problem with this. Because Blizz goes full retard and when 
in the same server the raid unit not only displays as "name" instead of 
"name-server" the UnitInRaid() function was losing the members on your same 
realm and in a raid group the EPGP functionality would be affected by the 
previous change I posted here :( so by changing all the data to always include 
the server on every UnitInRaid() function an Ambiguate(param, "none") the 
look-up will work just like the raid roster does making it work :D

Also I made the server name disappear from alts and the actual list to make it 
look nice but the side panels still show it so you know which person you are 
awarding EPGP to when you have members with the same name (shared servers allow 
this)

I kinda don't know ANYTHING of LUA and this was the first time I opened a LUA 
file so by all means if this fix has something wrong or I'm doing something I 
haven't do let me know but I'll leave the files here

Original comment by dsvict...@gmail.com on 26 Feb 2015 at 8:46

Attachments:

GoogleCodeExporter commented 8 years ago 
Excuse my terrible wording, I meant to say:

so to allow cross server functionality (the first fix I made) but avoid the 
raid roster to lose same realms characters, I included in every UnitInRaid() in 
the epgp.lua file an ambiguate none (instead of UnitInRaid(name) it is 
UnitInRaid(Ambiguate(name, "none")) to make sure this look-up works with the 
values that the raid frame shows, making it work

Original comment by dsvict...@gmail.com on 26 Feb 2015 at 8:59

GoogleCodeExporter commented 8 years ago 
I can confirm this issue.
My guild is original from realm A but with realm merges, we have lots of 
players from the merged realm B.
What happens is that if I check the List errors in the Epgp Configuration menu, 
I can see that EPGP is complaining about all the characters from realm B that 
have their main character in the alt's officer note.

In order to make it work, i had to rewrite all officer notes for alts that were 
related to main characters in realm B with the following format: 
CharacterName-RealmName
Although, I only had to do this for characters that were on realm B.

The problem is: i have officers on realm B, and this is a big problem because 
those officers cannot manage EPGP correctly. What happens on their side, is the 
exact same as me, but in the opposite direction.

I cannot stress enough how critical this issue is, because it breaks the alt 
management ability completly.

Original comment by clpalexa...@gmail.com on 23 Apr 2015 at 1:20

GoogleCodeExporter commented 8 years ago 
For anyone interested I made a fix for this to work. Unfortunately I play no 
more And the fix might conflict if the addon was updated after I made it, if 
not you can just copy and replace de lua files I modified. In any other case if 
you are adventurous enough my fix includes a txt file where I detail what I did 
on each file, each line and what it fixes. The last fix was on march 5 if the 
addon has been updated since that date, don't try to simply replace the files.

Go to your WoW add-ons folder, look for the epgp folder and once inside it copy 
we files and folders in the order they have. In-game all your officer notes 
should include your realm even if they are from the same realm as you. The list 
will not display the realm so it look nice but if you open the side panel it 
will show the realm (this is to be able to identify players with same name)

Original comment by dsvict...@gmail.com on 23 Apr 2015 at 2:51

Attachments:

GoogleCodeExporter commented 8 years ago 
I can confirm that the above fix works flawlessly! I've already contacted the 
devs so that they can look into this issue and fix...

Lets wait for some answer :)

Original comment by clpalexa...@gmail.com on 23 Jun 2015 at 7:04

GoogleCodeExporter commented 8 years ago 
Thanks for the patch.  I've uploaded it as v5.11.8; let me know how it works.

Original comment by chip.turner on 24 Jun 2015 at 3:35

GoogleCodeExporter commented 8 years ago 
Whooo im helping :D

Original comment by dsvict...@gmail.com on 24 Jun 2015 at 4:04

GoogleCodeExporter commented 8 years ago 
Your patch was great :)  Thanks for helping out!

Original comment by chip.turner on 24 Jun 2015 at 5:05

GoogleCodeExporter commented 8 years ago 
epgpweb really does not like the cross realm changes, you can uncheck 'show 
only members' but it does not correctly import character details etc.

Original comment by mar...@paradines.com on 25 Jun 2015 at 10:18