search

Maselkov / GW2RPC

Discord Rich Presence addon for Guild Wars 2
https://gw2rpc.info
GNU General Public License v3.0
46 stars 12 forks source link

Added option to close GW2RPC when GW2 closes #1

Closed arxae closed 6 years ago

arxae commented 6 years ago

When the GW2 process is no longer active, it will automatically shutdown GW2RPC Not tested yet as i currently have no access to GW2. Will do asap, just wanted to get PR up already since it should be a small change

arxae commented 6 years ago

The reasoning is that some people prefer to not have it (or any other unneeded programs) active when the game is not running, so i added the option for convenience. So when the game exits, GW2RPC exits along with it. It defaults to off to keep the original intent as default.

Maselkov commented 6 years ago

Thats fair

arxae commented 6 years ago

Is there still changes that are needed btw?

Maselkov commented 6 years ago

I believe it'll still raise a ValueError if user puts something other than the accepted values. Needs a try/except with default to false

arxae commented 6 years ago

You where correct. I assumed the fallback value also catched this (which was not the case)