Maselkov / GW2RPC

Discord Rich Presence addon for Guild Wars 2
https://gw2rpc.info
GNU General Public License v3.0
46 stars 12 forks source link

Installer always installs to `C:\Program Files\Guild Wars 2\addons\GW2RPC\` #33

Closed Fishrock123 closed 8 months ago

Fishrock123 commented 1 year ago

The installer always installs to C:\Program Files\Guild Wars 2\addons\GW2RPC\ even if you tell it otherwise.

My game is located at Z:\Games\Guild Wars 2\addons\GW2RPC\ for a bunch of reasons.

n1tr0-5urf3r commented 1 year ago

That's definitely not intended, thanks for reporting. I will investigate the issue, for now you can simply copy over the folder from C:\ to your GW2 install directory.

Fishrock123 commented 1 year ago

Yep, that’s what I ended up doing after several confusing attempts haha

Fishrock123 commented 1 year ago

I don’t know .nsi well, but I think the problem may be at https://github.com/Maselkov/GW2RPC/blob/master/dist/installer.nsi#L129 - should that $2 be $INSTDIR?

n1tr0-5urf3r commented 1 year ago

I think the issue is that the installer uses the GW2 installation path from the registry. Did you initially install the game on your C:\ drive and manually copied it over to your Z:\ drive? Can you check the registry value at HKEY_LOCAL_MACHINE\SOFTWARE\ArenaNet\Guild Wars 2\Path for me?

n1tr0-5urf3r commented 1 year ago

Nonetheless, the behavior of the installer to ignore the specified path if it detecs the GW2 installation path was not intended. I think I've found the issue, it should be fixed now :) I created a new release for this.