Crash/disconnect on inspection of file in VS Code

wisepotato commented 3 years ago

I am aware that this is not the vs code plugin repo, but the crash is in ccls, so i thouht it would fit here.

Observed behavior

I use VS Code to call ccls on my project it works great! but also crashes a lot. The (blurred for company specific details) error log:

15:38:16 indexer1         pipeline.cc:298 I load cache for $FILE
15:38:16 indexer0         pipeline.cc:298 I load cache for $FILE
15:38:16 indexer1         pipeline.cc:298 I load cache for $FILE
15:38:16 indexer0         pipeline.cc:298 I load cache for $FILE
15:38:16 indexer1         pipeline.cc:298 I load cache for $FILE
 #0 0x0000000001830bef PrintStackTraceSignalHandler(void*) (/home/$name/git/ccls/Release/ccls+0x1830bef)
 #1 0x000000000182e92e SignalHandler(int) (/home/$name/git/ccls/Release/ccls+0x182e92e)
 #2 0x00007f73d67755d0 __restore_rt (/lib64/libpthread.so.0+0xf5d0)
 #3 0x00000000017e1760 llvm::Twine::printOneChild(llvm::raw_ostream&, llvm::Twine::Child, llvm::Twine::NodeKind) const [clone .constprop.25] (/home/$name/git/ccls/Release/ccls+0x17e1760)
 #4 0x00000000017e1bc2 llvm::Twine::toVector(llvm::SmallVectorImpl<char>&) const (/home/$name/git/ccls/Release/ccls+0x17e1bc2)
 #5 0x00000000004675e7 ccls::pipeline::(anonymous namespace)::indexer_Parse(ccls::SemaManager*, ccls::WorkingFiles*, ccls::Project*, ccls::VFS*, ccls::GroupMatch const&) (/home/$name/git/ccls/Release/ccls+0x4675e7)
 #6 0x0000000000468976 ccls::pipeline::indexer_Main(ccls::SemaManager*, ccls::VFS*, ccls::Project*, ccls::WorkingFiles*) (/home/$name/git/ccls/Release/ccls+0x468976)
 #7 0x00000000004f0704 ccls::(anonymous namespace)::indexer(void*) (/home/$name/git/ccls/Release/ccls+0x4f0704)
 #8 0x00007f73d676ddd5 start_thread (/lib64/libpthread.so.0+0x7dd5)
 #9 0x00007f73d5837ead __clone (/lib64/libc.so.6+0xfdead)
ccls server connection was closed

compile_commands.json is setup correctly:

15:38:15 ccls              project.cc:426 I loaded blurred/compile_commands.json

it works great 50% of the time, and crashes indiscriminately. I have compiled both LLVM +CLANG and ccls and cmake (needed new version) from source.

Expected behavior

It to not crash.

Steps to reproduce

Start a project
click on cc file
boom

System information

ccls version (git describe --tags --long):
git describe --tags --long fatal: No names found, cannot describe anything.
clang version: non tag, hash: 502edebd9d6eb4665add9fd5edaa2dd1b1b24298
OS: WSL ubuntu via windows
Editor: VS COde
Language client (and version): english 1.56.2

wisepotato commented 3 years ago

seems to fail after a recompile. Will cross post to vs code repo

wisepotato commented 3 years ago

@MaskRay thanks for working on this proejct, i fixed it myself by setting both ccls and llvm to latest tag, might be worht adding to documentation.

MaskRay / ccls