MaskRay / ccls

C/C++/ObjC language server supporting cross references, hierarchies, completion and semantic highlighting
Apache License 2.0
3.77k stars 259 forks source link

Document offset counting method or(and?) implement clangd's LSP extension. #858

Closed black-desk closed 2 years ago

black-desk commented 2 years ago

I think we should document the offset encoding ccls use. So far this information can only be found in commit message.

https://github.com/neovim/nvim-lspconfig/pull/1649#issuecomment-1010539697

And should we implement clangd's LSP extension?

check https://clangd.llvm.org/extensions#utf-8-offsets

ccls can avoid the code point counting process when the client-side accepts utf-8 byte offset.

MaskRay commented 2 years ago

Does https://github.com/MaskRay/ccls/pull/859 work?

black-desk commented 2 years ago

work!

MaskRay commented 2 years ago

Merged #859