search

MaskRay / vscode-ccls

ccls plugin for Visual Studio Code
123 stars 37 forks source link

Improve 2 #36

Closed Yanpas closed 5 years ago

Yanpas commented 5 years ago

Fixes #35 an other issues as well

Yanpas commented 5 years ago

Concerning colors removal users are used to default theme with it's colors. I'm not sure if they will see this once: image

When there are too much colors it's hard to get their meaning

Yanpas commented 5 years ago

@Will-GXZ fixes #29 too

MaskRay commented 5 years ago

Why is the default color theme deleted?

Yanpas commented 5 years ago

The reasons are in second comment, vscode does it better. I think defaults for bold, italics and underlined should be revised too.

Coloring each existant semantic entity is meaningless. Purpose of syntax highlight is to show keywords and some parts to pay attention to. E.g. I think underlining global variables and coloring pass by nonconst reference makes a lot of sense.

Yanpas commented 5 years ago

Anyway some poll would be fair.

@Will-GXZ @Riatre what do you think?

Yanpas commented 5 years ago

@MaskRay Oh, nevermind, I didn't notice that there is 'enabled' setting which is off by default. Will revert my changes. I was enabling semantic if one of bold, italic and underline are true.

MaskRay commented 5 years ago

Manually cherry-picked..

Will-GXZ commented 5 years ago

Anyway some poll would be fair.

@Will-GXZ @Riatre what do you think?

To be honest, when I use ccls during work, I only use vscode default highlight. I tried turn on highlights setting before, but for me there were too many colors on the screen and they were kind of distracting.

I think underlining global variables and coloring pass by nonconst reference makes a lot of sense

-- I vote to this.